[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Add storage API support to test driver



On Wed, Oct 22, 2008 at 03:25:21PM -0400, Cole Robinson wrote:
> The attached patch implements the storage driver routines
> for the test driver. Most of the code is identical to
> storage_driver.c with all the references to backends
> removed. 
> 
> One caveat of this is that storage pools are hardcoded 
> to a specific size when they are defined: I figure someone
> could expand this to read sizes from xml at definition
> time if they wanted, but for now hardcoded values is
> sufficient.
> 
> I've done some decent testing with it all, so I'm pretty
> confident it isn't too broken.

  Looks good. Maybe it would be worth adding (but where)
in the test tree some example of the test XML definitions
you used.

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]