[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] PATCH: 2/11: Move internal error APIs into virterror_internal.h



On Thu, Oct 30, 2008 at 02:21:35PM +0000, Daniel P. Berrange wrote:
> On Thu, Oct 30, 2008 at 03:19:11PM +0100, Daniel Veillard wrote:
> > On Thu, Oct 30, 2008 at 01:36:10PM +0000, Daniel P. Berrange wrote:
> > > After Daniel's feedback that adding src/virterror.h is confusing, I've
> > > re-done the patch to instead add virterror_internal.h, making it clear
> > > that these function prototypes are related to virterror.c, but internal
> > > use only. That patch is basically moving them out of src/internal.h
> > > In addition it removes the leading __ prefix from virRaiseError since
> > > this symbol was never exported fromthe library.
> > > 
> > > The diff is mis-leading - most of this is just the s/__// change.
> > 
> >   Okay, I'm surprized that there is no more usage of internal.h, i would
> > have though it was still used widely for things like ATTRIBUTE_UNUSED, but
> > apparently not,
> 
> Actually, that's just a minor simplification on my part - virterror_internal.h
> will include internal.h, so there was no need to keep the explicit internal.h,
> though we could if you wanted. Ultimately every single file uses  the
> internal.h, via one or more of its includs.

  Ah, right, i missed that, now it's clear !
    thanks,

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]