[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] PATCH: don't print uninitialized integer in diagnostic



On Thu, Oct 30, 2008 at 05:26:21PM +0100, Jim Meyering wrote:
> In adding a test of the vcpu cpuset parsing code (another patch coming
> separately), I noticed a bogus diagnostic:
> 
>   virsh --connect test:///default dumpxml 1 > xml
>   sed "s/vcpu>/vcpu cpuset='aaa'>/" xml > xml-invalid
>   ./virsh --connect test:///default define xml-invalid 2>&1 |head -1
>   libvir: Domain Config error : failed Xen syscall topology cpuset syntax error -2027441560
> 
> With the patch below, I get this output instead:
> (i.e., same, but without the trailing negative number)
> 
>   $ ./virsh --connect test:///default define xml-invalid 2>&1 |head -1
>   libvir: Domain Config error : failed Xen syscall topology cpuset syntax error

  Ouch, sure, +1

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]