[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] introducing <source> <name> (for logical storage pools)



On Tue, 2008-09-02 at 08:50 +0200, Jim Meyering wrote:
> There, it'd be clearer to diagnose with something like
> "missing pool source device name", since there are a few
> other "name" elements.

I see Daniel V fixed this (and other) error messages to be less
ambiguous when he committed it earlier this morning.

> Not a show-stopper at all, but it'd be great if you could add a unit
> test or two, so this new code gets some regular coverage.

Are there any existing storage pool tests?  I can't find them.  I should
also add some unit tests for the storage pool discovery stuff.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]