[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[libvirt] Re: remote_protocol.{c,h} ?



On Wed, Sep 3, 2008 at 1:00 PM, Jun Koi <junkoi2004 gmail com> wrote:
> Hi,
>
> Is it really true that qemud/remote_protocol.{c,h} are created by
> rpcgen? If so, why dont we have them created at compile time? I still
> see them in the source code.
>
> I modified remote_protocol.x a bit, and when recompiling,
> remote_protocol.{c,h} are not reflected at all. So it is expected that
> developers must recompile with rpcgen themself??

I looked again, and see that we can generate remote_protocol.c from
rpcgen. Currently it seems remote_protocol.c is hacked a bit to remove
some unused stack variables? Why do we need to do such a thing, while
compiler can optimize that for us?

So I guess it is better to have rpcgen does all the job, and leave
everything as it is. We can rename remote_protocol_xdr.c to
remote_protocol.c if you still insist that (but I see no good reason
to do so).

Thanks,
Jun


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]