[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Fix disk device ordering



Daniel P. Berrange wrote:
> On Thu, Aug 21, 2008 at 11:21:15PM -0400, Cole Robinson wrote:
>> When parsing the domain xml, disks are supposed to be
>> rearranged in an alphabetic order based on bus type
>> and target. The reordering code had a flaw though, in
>> that it would always put the first disk it encountered
>> at the head of the list, and had no way of putting
>> new entries in front of it.
> 
> Hmm, yes good catch.
> 
>> The attached patch reworks the code to compare the new
>> disk against the current disk entry (rather than the
>> next entry like the existing code). Seems to pass all
>> my tests.
> 
> If the test suite passes that's good enough for me - we have a
> test case which explicitly does lots of disks with different
> buses & names for this.
> 
> 
> Daniel

Okay, I combined this with the previous patch to check for
target collisions and committed it.

Thanks,
Cole


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]