[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] xen: fix domain lookup after define



On Thu, Aug 28, 2008 at 10:19:01AM +0100, Daniel P. Berrange wrote:
> On Wed, Aug 27, 2008 at 08:57:24PM -0400, Cole Robinson wrote:
> > Defining a xen domain will succeed, but report
> > error because we weren't properly passing the
> > domain's name to the post-define lookup.
> 
> ACK, this was a mistake during the conversion to new APIs
> 
> > Attached patch fixes this, and also adds a
> > debug statement to show the sexpr we create
> > from the passed xml.
> 
> Good idea - there's been a number of BZ tickets where it would
> have been useful to ask the user to get this with LIBVIRT_DEBUG=1

  Agreed, looks fine to me, +1 !

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]