[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] PATCH: Latest MinGW patches



"Daniel P. Berrange" <berrange redhat com> wrote:
...
> Attached is a version with that change - though I had to make it 'int' for
> the return type since uid_t/gid_t don't exist on mingw either. Not that
> it matters, since we store the result in an int anyway
...

Thanks for reposting.
By the light of day, I spotted a minor quoting problem:

> Index: autobuild.sh
> ===================================================================
> RCS file: /data/cvs/libvirt/autobuild.sh,v
> retrieving revision 1.10
> diff -u -p -r1.10 autobuild.sh
> --- autobuild.sh	28 Aug 2008 09:08:44 -0000	1.10
> +++ autobuild.sh	4 Sep 2008 11:00:17 -0000
> @@ -17,8 +17,6 @@ rm -rf coverage
>  ./autogen.sh --prefix="$AUTOBUILD_INSTALL_ROOT" \
>    --enable-test-coverage \
>    --enable-compile-warnings=error \
> -  --with-openvz \
> -  --with-lxc \
>    --with-xen-proxy
>
>  # If the MAKEFLAGS envvar does not yet include a -j option,
> @@ -44,6 +42,7 @@ test -x /usr/bin/lcov && make cov
>  rm -f *.tar.gz
>  make dist
>
> +

accidentally added?  no big deal, of course

>  if [ -f /usr/bin/rpmbuild ]; then
>    if [ -n "$AUTOBUILD_COUNTER" ]; then
>      EXTRA_RELEASE=".auto$AUTOBUILD_COUNTER"
> @@ -51,5 +50,40 @@ if [ -f /usr/bin/rpmbuild ]; then
>      NOW=`date +"%s"`
>      EXTRA_RELEASE=".$USER$NOW"
>    fi
> -  rpmbuild --nodeps --define "extra_release $EXTRA_RELEASE" -ta --clean *.tar.gz
> +
> +  rpmbuild --nodeps \
> +     --define "extra_release $EXTRA_RELEASE" \
> +     --define "_sourcedir `pwd`" \
> +     -ba --clean libvirt.spec
> +fi
> +
> +if [ -x /usr/bin/i686-pc-mingw32-gcc ]; then
> +  make distclean
> +
> +  PKG_CONFIG_PATH=$AUTOBUILD_INSTALL_ROOT/i686-pc-mingw32/sys-root/mingw/lib/pkgconfig \
> +  CC="i686-pc-mingw32-gcc" \

you might want to omit the unnecessary double quotes here,
to be consistent e.g., with host=i686... below.

> +  ./configure \
> +    --build=$(uname -m)-pc-linux \
> +    --host=i686-pc-mingw32 \
> +    --prefix=$AUTOBUILD_INSTALL_ROOT/i686-pc-mingw32/sys-root/mingw \

Here, however, you should add quotes around $AUTOBUILD_INSTALL_ROOT,
since it's coming from the environment and may contain spaces or worse.

       --prefix="$AUTOBUILD_INSTALL_ROOT/i686-pc-mingw32/sys-root/mingw" \

> +    --without-sasl \
...


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]