[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Fix capacity reporting for qcow2 images



On Tue, Sep 02, 2008 at 05:17:56PM -0400, Cole Robinson wrote:
> Libvirt was reporting some ridiculously large 'capacity'
> values for some qcow2 images I was creating with relatively
> small sizes (200 MB). Seems there was a signedness problem
> when parsing the file header. The attached fix shows the
> expected values and doesn't look like it will hurt elsewhere.

  Okay, that looks sensible, but man that's code from the 80's
do we still need to poke like this in modern code to make those
estimates ? That's scary (the function, not the patch :-)

  Applied and commited,

Daniel


-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]