[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] PATCH: Switch openvz driver to domain APIs



On Fri, Aug 29, 2008 at 12:54:18PM +0400, Evgeniy Sokolov wrote:
> >On Thu, Aug 28, 2008 at 12:06:08PM +0400, Evgeniy Sokolov wrote:
> >>>The biggest flaw I see currently is that the
> >>>openvz driver doesn't load the existing device config for networks or
> >>>filesystems of existing VMs, so you can't see that info in the XML dump
> >>Yes. Good note. I will implement it.
> >>>-        /*get VCPU*/
> >>>-        ret = openvzReadConfigParam(veid, "CPUS", temp, sizeof(temp));
> >>>-        if (ret < 0) {
> >>>-             openvzError(conn, VIR_ERR_INTERNAL_ERROR,
> >>>-                            _("Cound not read config for container 
> >>>%d"), veid);
> >>>-             goto error;
> >>>-        } else if (ret > 0) {
> >>>-             vmdef->vcpus = strtoI(temp);
> >>>-        }
> >>Why did you remove loading VCPUs and always set = 1 ?
> >
> >Stupid mistake during a manual merge. Here's an updated patch which
> >fixes that mistake
> 
> The patch looks good now.

Thanks - i've committed this patch now, so now all our drivers are using
the same XML processing APIs !

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]