[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Implement vol delete for disk pools



On Mon, Sep 08, 2008 at 09:33:40AM -0400, Cole Robinson wrote:
> Daniel Veillard wrote:
> >> +    devname = basename(devpath);
> >> +    srcname = basename(pool->def->source.devices[0].path);
> > 
> >   This seems to leak the two strings and not check for errors. That
> > would need to be fixed before being commited IMHO
> > 
> 
> glibc defines basename in string.h as:
> 
> char *
> basename (filename)
>      const char *filename;

  I got fooled by the char * return value, my bad,

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]