[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Use gcc style for structure fields declaration



On Fri, Aug 29, 2008 at 3:02 PM, Jim Meyering <jim meyering net> wrote:
> "Nguyen Anh Quynh" <aquynh gmail com> wrote:
>> Hmm there are some typos (listDomain -> listDefinedDomain,
>> numOfDomains -> numOfDefineDomains)
>>
>> Please take this patch instead.
>>  static virDriver lxcDriver = {
>> -    VIR_DRV_LXC, /* the number virDrvNo */
>> -    "LXC", /* the name of the driver */
>> -    LIBVIR_VERSION_NUMBER, /* the version of the backend */
>> -    lxcProbe, /* probe */
> ...
>> +    .no = VIR_DRV_LXC, /* the number virDrvNo */
>> +    .name = "LXC", /* the name of the driver */
>> +    .ver = LIBVIR_VERSION_NUMBER, /* the version of the backend */
>> +    .probe = lxcProbe,
> ...
>
> Thank you.  That looks like a fine improvement.
>
> Have you already compared the pre- and post-patch .o files?
> This patch appears to be one that would evoke no change in any
> recompiled .o file.
> If so, and if you can report that all four pre/post .o-file pairs are
> identical, we can be sure this improvement does not hide a subtle bug.
>

I tried, and saw nothing wrong. Could you confirm that?

Thanks,
Quynh


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]