[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[libvirt] [PATCH] Wrong comments



Hi!

In comments to structure 'virDomainInfo' there was reference to smth of type 'virDomainFlags'. Actually, the type of this field must be 'virDomainState'.
Patch includes another one such replacement.

There is another place where 'virDomainFlags' mentioned: src/xend_internal.c. I think, that argument must be of type 'virConnectFlags',
but it is marked as ATTRIBUTE_UNUSED, so I leave the comment as it is :)

And why are you writing
    unsigned char state;
instead of
    virDomainState state;
?

Anton

Attachment: libvirt-wrong-comments.diff
Description: Binary data


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]