[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] read network config in OpenVZ driver



On Thu, Sep 18, 2008 at 03:47:53PM +0400, Evgeniy Sokolov wrote:
>
>> On Wed, Sep 17, 2008 at 08:28:56PM +0400, Evgeniy Sokolov wrote:
>>> I attached patch without hunk which was commited by Daniel.
>>> Please commit if you are agree with it.
>>
>> A few comments inline..
>>
> ...
>>
>> So you're not artifically restricting the max length of the
>> network name.
> It is limit in OpenVZ kernel. I did not remove check for max length.
>>
>
> Thanks for review. Corrected patch is attached.

  Okay looks fine to me and that wasn't applied so I  pushed this to
CVS. Maybe the MAC parsing code could reuse virParseMacAddr() instead
of calling scanf but that's cosmetic,

   thanks !

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]