[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/3]: Cleanup the virStorageDriver structs



On Tue, Sep 23, 2008 at 07:34:17AM +0200, Chris Lalancette wrote:
> Daniel Veillard wrote:
> > On Fri, Sep 19, 2008 at 10:36:37AM +0200, Chris Lalancette wrote:
> >> This patch just cleans up the virStorageDriver structs so that they use the
> >> functionPointer = functionname syntax of gcc.  This makes it much easier to
> >> grep in the code later.  This patch also re-arranges the order of the function
> >> pointers in remote_internal so that it matches the definition of
> >> virStorageDriver in src/driver.h.  While not strictly necessary, it does make it
> >> a little more sane when looking at it in the future.
> > 
> >   Okidoc, uncontroversial, so applied and commited,
> > 
> >     thanks !
> 
> Thanks for committing DV.  I still have to work on answering danpb's one other
> question on patch 3 (hopefully today), and then I'll post answers/updated patch
> for that one.

  Yup, note that I commited patch 3 too, the controversial point is
trivial to revert, and assuming we need different handling for pre F-9
and post F-9 having a separate patch about the issue is probably nicer
too.

  Still I'm surprized ad the -f force option seems present on my lvm2
version on RHEL5:

test:~ -> vgremove --help 2>/dev/null | grep force
    [-f|--force]
test:~ -> rpm -qif `which vgremove`
Name        : lvm2                         Relocations: (not
relocatable)
Version     : 2.02.32                           Vendor: Red Hat, Inc.
Release     : 4.el5                         Build Date: Fri 04 Apr 2008
01:15:19 PM CEST
Install Date: Thu 12 Jun 2008 03:15:52 PM CEST      Build Host:
hs20-bc2-3.build.redhat.com

  the rpm was built recently, and apparently the update to upstream was
  done around January

* Thu Jan 17 2008 Milan Broz <mbroz redhat com> - 2.02.30-1
- Update to latest upstream release.

  Are you sure the -f option is really the problem you're seing ?
Maybe I'm just confused, which is quite possible too :-)

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]