[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[libvirt] [PATCH] Fix > 1 char device for qemu VM



Trying to start a qemu guest with more than 1 character
device (serial or parallel, doesn't count for console)
always times out. There was an error in the code that
would strip the pty path qemu spits out, which
confused the parsing after being called more than twice.

The attached patch fixes this. I verified that guests
with 0, 1, and 2 serial devices all boot fine.

Thanks,
Cole
diff --git a/src/qemu_driver.c b/src/qemu_driver.c
index 9d8f75a..a1e7285 100644
--- a/src/qemu_driver.c
+++ b/src/qemu_driver.c
@@ -566,7 +566,7 @@ static int qemudExtractMonitorPath(virConnectPtr conn,
             strncpy(*path, dev, (tmp-dev));
             (*path)[(tmp-dev)] = '\0';
             /* ... now further update offset till we get EOL */
-            *offset += tmp - haystack;
+            *offset = tmp - haystack;
             return 0;
         }
         tmp++;

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]