[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/1] Add SCSI pool support.



On Tue, Mar 31, 2009 at 05:49:47PM -0400, Dave Allan wrote:
> Dave Allan wrote:
> Attached is what I think is a final version of the scsi host pool code.  
> It's the set of patches we've been discussing rolled up into a single  
> patch, so it should look ok, but let me know if you have additional  
> comments.  I allowed both disk and rom and took out the XML enhancement  
> for device type.
>
> Dave

  Patch looks fine to me, but I admit I didn't tested it

[...]
> --- a/src/storage_conf.c
> +++ b/src/storage_conf.c
> @@ -187,6 +187,14 @@ static virStoragePoolTypeInfo poolTypeInfo[] = {
>              .formatToString = virStoragePoolFormatDiskTypeToString,
>          }
>      },
> +    { .poolType = VIR_STORAGE_POOL_SCSI,
> +      .poolOptions = {
> +            .flags = (VIR_STORAGE_POOL_SOURCE_ADAPTER),
> +        },
> +      .volOptions = {
> +            .formatToString = virStoragePoolFormatDiskTypeToString,
> +        }
> +    },
>      { .poolType = VIR_STORAGE_POOL_DISK,
>        .poolOptions = {
>              .flags = (VIR_STORAGE_POOL_SOURCE_DEVICE),

  I think at some point the C99 initialization should be turned back
  into plain old initialization, but that's something we should probably
  do more globally independantly.

   Thanks,

Daniel


-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]