[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Fix test driver 'restore' return value



On Thu, Apr 02, 2009 at 02:00:07PM -0400, Cole Robinson wrote:
> The return value for domain restore in the test driver isn't consistent
> with the API, and as such virsh will report failure even if the restore
> succeeds. The attached patch fixes this.

ACK.

Daniel

> commit 5fd0612bae3e67bd1496cf175b742fea962d9977
> Author: Cole Robinson <crobinso redhat com>
> Date:   Thu Apr 2 13:49:40 2009 -0400
> 
>     Fix test driver domain restore return value.
> 
> diff --git a/src/test.c b/src/test.c
> index a5422e9..a518737 100644
> --- a/src/test.c
> +++ b/src/test.c
> @@ -1337,7 +1337,7 @@ static int testDomainRestore(virConnectPtr conn,
>      event = virDomainEventNewFromObj(dom,
>                                       VIR_DOMAIN_EVENT_STARTED,
>                                       VIR_DOMAIN_EVENT_STARTED_RESTORED);
> -    ret = dom->def->id;
> +    ret = 0;
>  
>  cleanup:
>      virDomainDefFree(def);


-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]