[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/1] Add trigger of host rescan



Daniel Veillard wrote:
On Tue, Apr 07, 2009 at 10:21:37AM +0100, Daniel P. Berrange wrote:
On Mon, Apr 06, 2009 at 11:41:48AM -0400, Dave Allan wrote:
static int
+virStorageBackendSCSIStartPool(virConnectPtr conn ATTRIBUTE_UNUSED,
+ virStoragePoolObjPtr pool ATTRIBUTE_UNUSED)
+{
+    int retval = 0;
+
+    return retval;
+}
+
+
+static int
+virStorageBackendSCSIStopPool(virConnectPtr conn ATTRIBUTE_UNUSED,
+                              virStoragePoolObjPtr pool ATTRIBUTE_UNUSED)
+{
+    int retval = 0;
+
+    return retval;
+}
 Is that really better than suggesting the operation is not supported ?
These two functions are, of course, not required for this patch. They're there because I had started to implement NPIV support and then thought I should submit this patch before the NPIV patch. I can take them out if you'd like and add them to the subsequent patch where they will have contents.
Yep, prefer to leave them out if they're unrelated to this patch.
[...]
ACK

  Okay, so I commited a version without virStorageBackendSCSIStartPool
and Stop, I also changed the write() call to safewrite() !

Ok, great--thanks!

Dave


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]