[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] test driver for interface config



On Tue, 2009-04-07 at 16:35 +0100, Daniel P. Berrange wrote:
> Even though its doing a passthrough to netcf library, the netcf driver
> would still need to parse the XML in accordance with libvirt
> defined schema. It just happens that netcf uses the same XML
> format, so it can then convert it back into XML and pass it on
> through to netcf. 

While that is still the case (libvirt interafce XML == netcf XML), it
makes more sense to exercise as much of netcf as possible in the tests.
The 'root' argument to ncf_init makes that possible, and if there are
other things needed, we should add it to netcf, and exercise as many as
the same code paths as non-test uses will as possible.

> The test driver wouldn't call anything in netcf. It is intended to
> be an entirely self-contained in-memory impl of the APIs with all the
> semantics required by the public APIs.

Given that the libvirt API is just pass-through for now, that would test
much less of the 'live' code than we can and should exercise.

David



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]