[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/2] VirtualBox support (Resending by fixing a autodetection Bug)



Hi Daniel,

> > +char g_szVBoxErrMsg[256];
>
> I don't much like the static fixed size error message buffer

Fixed this.

> > +    if (conn->uri == NULL) {
> > +        conn->uri = xmlParseURI(uid ? "vbox:///session" :
> > "vbox:///system"); +        if (conn->uri == NULL) {
> > +            vboxError(conn, VIR_ERR_NO_DOMAIN, NULL);
> > +            return VIR_DRV_OPEN_ERROR;
>
> Minor bug here, the VIR_ERR_NO_DOMAIN error isn't the correct code for an
> URI parsing error :-)

Fixed this as well. Will post a patch along with others changes suggested on 
the list.

Regards,
Pritesh


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]