[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] respect debug level for domain log file



On Thu, Apr 16, 2009 at 05:32:06PM +0200, Daniel Veillard wrote:
> On Thu, Apr 16, 2009 at 03:38:40PM +0200, Guido Günther wrote:
> > On Thu, Apr 16, 2009 at 01:29:08PM +0100, Daniel P. Berrange wrote:
> > > On Thu, Apr 16, 2009 at 02:17:29PM +0200, Guido G?nther wrote:
> > > > Hi,
> > > > currently every monitor command is dumped into the domain logfiles, this
> > > > can lead to huge logs[1]. Since we're not going through the normal
> > > > logging facilites to get per domain logfiles we should at least resepct
> > > > the default priority.
> > > 
> > > IMHO this should just be removed. We already have ability to log all
> > > monitor commands via the normal logging mechanism, so we no longer have a
> > > need to write them out to the domain logs. We should leave the domain logs
> > > just for QEMU's stdout/err as we originally had them. 
> > I'm all for it since this makes reparsing the log output safer too.
> > 
> > Attached patch remove the monitor output from the domain log file. To
> > compensate it prefixes the debug replies with the vm name so it's easier
> > to find out what's wrong on a crowded system.
> 
>   Sounds good to me. I think there is many places where we could add
> a bit more DEBUG statements, I laready had to do this kind of changes to
> tracks some allocation bugs and it would have been nicer if the DEBUG
> were in the compiled binaries.
> 
>   ACK
Also applied.
 -- Guido


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]