[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] PATCH: Use virDomainDefPtr to build QEMU args instead of virDomainObjPtr



On Fri, Apr 17, 2009 at 01:11:37PM +0200, Daniel Veillard wrote:
> On Fri, Apr 17, 2009 at 11:41:41AM +0100, Daniel P. Berrange wrote:
> > This is a fairly simple NFC patch which changes the QEMU driver to use
> > the virDomainDefPtr object when building command line arguments instead
> > of the virDomainObjPtr. The command line building only needs the config,
> > and none of the state, so virDomainDefPtr was more applicable.
> > 
> > This was a pre-requisite for another patch I wrote, but have since
> > thrown away. I think this one is worth applying anyway as a general
> > cleanup.
> 
>   Yup, interesting decoupling, ACK

Comitted now

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]