[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] PATCH: Remove PID file before starting QEMU, and after shutdown



On Mon, Apr 20, 2009 at 01:52:30PM +0100, Daniel P. Berrange wrote:
> We spawn QEMU with a -pidfile option to write its PID out to a file. This
> file is never removed though, so next time the guest starts there is small
> race condition where we might be unlucky enough to read the old PID out of
> the file, instead of the new QEMU PID.  This patch adds a call to remove
> the pidfile from disk when a guest is shut down. As an extra preventative
> measure, we also delete it before starting a guest 

  Looks right to me ! ACK

   thanks !

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]