[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] PATCH: Fix compiler flag check for -Wformat-security



On Mon, Apr 27, 2009 at 11:37:35AM +0100, Daniel P. Berrange wrote:
> Certain versions of GCC will ignore the -Wformat-security flag unless you
> have also set the -Wformat flag. Unfortunately when checking flags, we only
> check one at a time in isolation, so it was thinking -Wformat-security
> is not supported in Fedora. The fix is to include all previously verified
> flags during the check process, but not for -Werror because for added fun,
> the autoconf test program itself causes compile warnings with some flags
> we have. The patch also fixes 3 harmless format problems in virsh

  Thanks for chasing this issue, all looks good, ACK.

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]