[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Remove unused file volume format 'dir'



Daniel P. Berrange wrote:
> On Tue, Apr 28, 2009 at 12:33:24PM -0400, Cole Robinson wrote:
>> It isn't documented, detected, and barely has any code accomodating it.
>> Appears to be left over from an earlier iteration of the storage APIs.
>>
>> commit 2aec7c2f843d30e5b6882b8a335494a2de7bc156
>> Author: Cole Robinson <crobinso redhat com>
>> Date:   Wed Apr 22 14:54:31 2009 -0400
>>
>>     Remove storage volume format 'dir'
>>     
>>     Isn't documented, detected, and barely has any code accomodating it. Appears
>>     to be left over from an earlier iteration of the storage APIs.
> 
> This is actually made available for end user applications  that need to
> know about directories. eg if creating a container, you may have a file
> based pool with directories for various container roots.  So I don't
> think we should be removing this.
> 

Works for me, I'll drop this patch.

Thanks,
Cole


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]