[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[libvirt] PATCH: Raise log level for dlopen() problems



Some of the problems when dlopen'ing a module really should be reported to
the user/admin more readily. So this raises the logging level for the
important failure messages, so they're visible by default

Daniel

diff -r 15c4668d403b src/driver.c
--- a/src/driver.c	Wed Apr 29 15:29:17 2009 +0100
+++ b/src/driver.c	Thu Apr 30 14:49:27 2009 +0100
@@ -54,13 +54,13 @@ virDriverLoadModule(const char *name)
         return NULL;
 
     if (access(modfile, R_OK) < 0) {
-        DEBUG("Moodule %s not accessible", modfile);
+        VIR_WARN("Module %s not accessible", modfile);
         goto cleanup;
     }
 
     handle = dlopen(modfile, RTLD_NOW | RTLD_LOCAL);
     if (!handle) {
-        DEBUG("failed to load module %s %s", modfile, dlerror());
+        VIR_ERROR("failed to load module %s %s", modfile, dlerror());
         goto cleanup;
     }
 
@@ -70,12 +70,12 @@ virDriverLoadModule(const char *name)
 
     regsym = dlsym(handle, regfunc);
     if (!regsym) {
-        DEBUG("Missing module registration symbol %s", regfunc);
+        VIR_ERROR("Missing module registration symbol %s", regfunc);
         goto cleanup;
     }
 
     if ((*regsym)() < 0) {
-        DEBUG("Failed module registration %s", regfunc);
+        VIR_ERROR("Failed module registration %s", regfunc);
         goto cleanup;
     }
 


-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]