[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Add a comment about setting errors after qemudStartVMDaemon().



Daniel P. Berrange wrote:
> On Fri, Jul 31, 2009 at 03:20:01PM +0200, Chris Lalancette wrote:
>> Signed-off-by: Chris Lalancette <clalance redhat com>
>> ---
>>  src/qemu_driver.c |    3 +++
>>  1 files changed, 3 insertions(+), 0 deletions(-)
>>
>> diff --git a/src/qemu_driver.c b/src/qemu_driver.c
>> index fcfbfbc..eadb53f 100644
>> --- a/src/qemu_driver.c
>> +++ b/src/qemu_driver.c
>> @@ -6390,6 +6390,9 @@ qemudDomainMigratePrepare2 (virConnectPtr dconn,
>>       */
>>      snprintf (migrateFrom, sizeof (migrateFrom), "tcp:0.0.0.0:%d", this_port);
>>      if (qemudStartVMDaemon (dconn, driver, vm, migrateFrom, -1) < 0) {
>> +        /* Note that we don't set an error here because qemudStartVMDaemon
>> +         * should have already done that.
>> +         */
>>          if (!vm->persistent) {
>>              virDomainRemoveInactive(&driver->domains, vm);
>>              vm = NULL;
> 
> ACK

Committed.

-- 
Chris Lalancette


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]