[libvirt] [PATCH] Add some automatic dependency checks for configure to enable/disable {ESX, UML, LXC, Xen-Inotify}
Daniel Veillard
veillard at redhat.com
Wed Aug 5 09:00:03 UTC 2009
On Thu, Jul 30, 2009 at 09:25:55PM +0200, Maximilian Wilhelm wrote:
> Hi!
>
> While building libVirt on an older Debian Etch machine, I stumbled
> across some automatic enabled drivers which stopped configure and make
> very badly due to missing header files, old libraries and stuff.
>
> So I decided to improve the automagic tests so others won't face the
> same problem again :)
>
> Find four patches attached.
Okay those make sense, I just had to fix
> dnl
> -dnl check for libcurl
> +dnl check for libcurl (ESX)
> dnl
>
> LIBCURL_CFLAGS=""
> @@ -1147,13 +1147,17 @@ LIBCURL_LIBS=""
> LIBCURL_REQUIRED="7.18.0"
> LIBCURL_FOUND="no"
>
> -if test "$with_esx" = "yes" ; then
> - PKG_CHECK_MODULES(LIBCURL, libcurl >= $LIBCURL_REQUIRED, [LIBCURL_FOUND=yes], [LIBCURL_FOUND=no])
> -
> - if test "$LIBCURL_FOUND" = "no"; then
> - AC_MSG_CHECKING(for libcurl libraries >= $LIBCURL_REQUIRED)
> - AC_MSG_ERROR([libcurl >= $LIBCURL_REQUIRED is required for the ESX driver])
> - fi
> +if test "$with_esx" = "yes" -o "$with_esx" = "check"; then
> + PKG_CHECK_MODULES(LIBCURL, libcurl >= $LIBCURL_REQUIRED, [
> + LIBCURL_FOUND=yes
adding a missing with_esx=yes here, so that at the end we see
configure: ESX: yes
instead of
configure: ESX: check
I also moved the libcurl output in the lib section instead of "Driver
Loadable Modules" but that's unrelated to the patch.
The other 3 patches were just fine as-is, applied and commited,
thanks !
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
daniel at veillard.com | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library http://libvirt.org/
More information about the libvir-list
mailing list