[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Support the usage of socat instead of netcat



On Wed, Aug 05, 2009 at 12:58:33PM +0200, Jonas Eriksson wrote:
> Some netcat implementations does not support unix domain sockets (-U).
> Distros that ship these implementations often also ships socat, that
> do support this.
> 
> This is a reworked patch based on the openSUSE libvirt package. The
> original patch may be found in this source rpm:
> http://download.opensuse.org/source/distribution/11.1/repo/oss/suse/src/libvirt-0.4.6-11.1.src.rpm
> 
> * configure.in: Check for --with-socat and set USE_SOCAT in config.h
> 
> * src/remote_internal.c: Honour USE_SOCAT by selecting between
>   netcat/nc and socat at compile time.

Changing the binary used at compile time is really not a good idea,
because libvirt uses netcat on the remote machine, which is not
required to be the same distro as the client machine on whihc you
built libvirt. So by making socat vs netcat a compile time option
you pretty much guarentee incompatibility between libvirt client & 
server betweeen distros. It is really better to fix netcat on the
distros where -U isn't available.

Regards,
Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]