[libvirt] VMware ESX 1/3: Add proper OOM reporting for esxDomainGetOSType
Daniel P. Berrange
berrange at redhat.com
Thu Aug 6 11:42:24 UTC 2009
On Wed, Aug 05, 2009 at 03:22:51PM +0200, Matthias Bolte wrote:
> Subject says it all.
>
> Matthias
5B> diff --git a/src/esx/esx_driver.c b/src/esx/esx_driver.c
> index dba6305..8b8575c 100644
> --- a/src/esx/esx_driver.c
> +++ b/src/esx/esx_driver.c
> @@ -1395,9 +1395,16 @@ esxDomainDestroy(virDomainPtr domain)
>
>
> static char *
> -esxDomainGetOSType(virDomainPtr dom ATTRIBUTE_UNUSED)
> +esxDomainGetOSType(virDomainPtr domain)
> {
> - return strdup("hvm");
> + char *osType = strdup("hvm");
> +
> + if (osType == NULL) {
> + virReportOOMError(domain->conn);
> + return NULL;
> + }
> +
> + return osType;
> }
ACK, trivial fix.
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
More information about the libvir-list
mailing list