[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/5] Several fixes to libvirtd's log setup



On Fri, Jul 31, 2009 at 05:57:31PM -0400, Amy Griffis wrote:
> Similar as for general libvirt, don't convert high priority levels to debug
> level. Ignore LIBVIRT_LOG_FILTERS and LIBVIRT_LOG_OUTPUTS when they're set to
> the empty string, otherwise they can override a valid setting from the config
> file. Send all settings through the parser functions for validation, so that the
> existence of a bad setting doesn't nullify a good setting that should have
> applied -- particularly the default output. Keep the order of precedence
> consistent for all variables between the environment and the config file.
> Warn when an invalid log level, filter, or output is ignored.

  Okay, nice ! I just had to clear up an end of line space in a comment,

    commited,

 thanks !

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]