[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 12/20] Attach encryption information to virStorageVolDef.



----- "Daniel P. Berrange" <berrange redhat com> wrote:
> >    <define name='vol'>
> >      <element name='volume'>
> > @@ -74,6 +76,7 @@
> >        </optional>
> >        <ref name='format'/>
> >        <ref name='permissions'/>
> > +      <ref name='encryption'/>
> >      </element>
> >    </define>
> 
> To allow removal of "<encryption>" for non-encrypted cases, I
> believe we'd need to add   
> 
>   <optional>
>     <ref name='encrption'/>
>   </optional>
> 
> Unless that's 'encryption' schema rule itself has <optional>
> already ?
Yes, it currently does.  I'll move the <optional> to the users, to be more explicit.

Thanks for the review,
   Mirek


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]