[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] PATCH: Support setting a disk drive serial (number)



On Tue, Aug 18, 2009 at 11:03:44AM +0200, Daniel Veillard wrote:
> On Mon, Aug 17, 2009 at 06:12:55PM +0100, Daniel P. Berrange wrote:
> [...]
> > +            if (disk->serial)
> > +                virBufferVSprintf(&opt, ",serial=%s", disk->serial);
> 
>    Sounds fine, just that if the content is free form maybe one need
> to quote that argument
> 
>     ",serial='%s'"
> 
> to avoid potential problems.

That would be a nice idea if QEMU actually supported quoting :-)

It treats the value as any character following the '=' up until the
next ',' (or end of string).

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]