[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] PATCH: Support setting a disk drive serial (number)



On Tue, Aug 18, 2009 at 04:39:32PM +0100, Daniel P. Berrange wrote:
> On Tue, Aug 18, 2009 at 11:03:44AM +0200, Daniel Veillard wrote:
> > On Mon, Aug 17, 2009 at 06:12:55PM +0100, Daniel P. Berrange wrote:
> > [...]
> > > +            if (disk->serial)
> > > +                virBufferVSprintf(&opt, ",serial=%s", disk->serial);
> > 
> >    Sounds fine, just that if the content is free form maybe one need
> > to quote that argument
> > 
> >     ",serial='%s'"
> > 
> > to avoid potential problems.
> 
> That would be a nice idea if QEMU actually supported quoting :-)
> 
> It treats the value as any character following the '=' up until the
> next ',' (or end of string).

  OMG !

Any further comment removed before sending ...

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]