[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 03/20] Secret manipulation step 3: Public API implementation



On Sun, Aug 16, 2009 at 10:47:56PM +0200, Miloslav Trmač wrote:
> Changes since the second submission:
> - Update for the changed public API
> - s/secret_id/uuid/g
> - use "unsigned char *" for secret value
[...]
> +/**
> + * virConnectListSecrets:
> + * @conn: virConnect connection
> + * @uuids: Pointer to an array to store the UUIDs
> + * @maxuuids: size of the array.

just add flags

> + *
> + * List UUIDs of defined secrets, store pointers to names in uuids.
> + *
> + * Returns the number of UUIDs provided in the array, or -1 on failure.
> + */
> +int
> +virConnectListSecrets(virConnectPtr conn, char **uuids, int maxuuids)
> +{
> +/**
> + * virSecretDefineXML:
> + * @conn: virConnect connection
> + * @xml: XML describing the secret.

  let's add flags here too

> + * If XML specifies an UUID, locates the specified secret and replaces all
> + * attributes of the secret specified by UUID by attributes specified in xml
> + * (any attributes not specified in xml are discarded).
> + *
> + * Otherwise, creates a new secret with an automatically chosen UUID, and
> + * initializes its attributes from xml.
> + *
> + * Returns a the secret on success, NULL on failure.
> + */
[...]
> +/**
> + * virSecretGetXMLDesc:
> + * @secret: A virSecret secret
 here too
> + * Fetches an XML document describing attributes of the secret.
> + *
> + * Returns the XML document on success, NULL on failure.  The caller must
> + * free() the XML.
> + */
> +char *
> +virSecretGetXMLDesc(virSecretPtr secret)

> +/**
> + * virSecretSetValue:
> + * @secret: A virSecret secret
> + * @value: Value of the secret
> + * @value_size: Size of the value

  here

> + * Sets the value of a secret.
> + *
> + * Returns 0 on success, -1 on failure.
> + */

> +/**
> + * virSecretGetValue:
> + * @secret: A virSecret connection
> + * @value_size: Place for storing size of the secret value

  and here

> + * Fetches the value of a secret.
> + *
> + * Returns the secret value on success, NULL on failure.  The caller must
> + * free() the secret value.
> + */

  otherwise libvirt.c code looks just fine

> diff --git a/src/virterror.c b/src/virterror.c
> index 83a0830..2a3cdaf 100644
> --- a/src/virterror.c
> +++ b/src/virterror.c

  ACK once flags are added,

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]