[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Fix virDomainObj ref handling in QEMU driver



2009/12/8 Daniel P. Berrange <berrange redhat com>:
> Since the monitor I/O is processed out of band from the main
> thread(s) invoking monitor  commands, the virDomainObj may be
> deleted by the I/O thread. The qemuDomainObjBeginJob takes an
> extra reference to protect against final deletion, but this
> reference is released by the corresponding EndJob call. THus
> after the EndJob call it may not be valid to reference the
> virDomainObj any more. To allow callers to detect this, the
> EndJob call is changed to return the remaining reference count.
>

ACK. Together with your 'QEMU text monitor parsing' patch I get
successful TCK runs. Thanks.

Matthias


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]