[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/5] reload iptables rules on libvirtd restart



On Thu, Dec 10, 2009 at 11:27:52AM +0000, Mark McLoughlin wrote:
> This is the expected behaviour, I think - reloading libvirtd should
> be a subset of restarting it.
> 
> Note, we reload the rules after we've determined which networks
> are active (because we only add the rules for active networks)
> and before we start autostart networks (to avoid re-adding the
> rules).
> 
> * src/network/bridge_driver.c: reload iptables rules on startup
> ---
>  src/network/bridge_driver.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c
> index 766f8cd..d5cab71 100644
> --- a/src/network/bridge_driver.c
> +++ b/src/network/bridge_driver.c
> @@ -259,6 +259,7 @@ networkStartup(int privileged) {
>          goto error;
>  
>      networkFindActiveConfigs(driverState);
> +    networkReloadIptablesRules(driverState);
>      networkAutostartConfigs(driverState);
>  
>      networkDriverUnlock(driverState);

ACK


Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]