[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 5/5] remove now unneeded iptablesContext



On Thu, Dec 10, 2009 at 11:27:55AM +0000, Mark McLoughlin wrote:
> iptablesContext no longer contains any state, so we can drop it
> 
> * src/util/iptables.c, src/util/iptables.h: drop iptablesContext
> 
> * src/network/bridge_driver.c: update callers
> 
> * src/libvirt_private.syms: drop context new/free functions


Ordinarily I'd ACK this, but one of the things I want to try and do
in the future is to move all the libvirt rules out of the main 
INPUT/FORWARD/OUPUT chains, and into sub-chains. I think that the
iptablesContxt struct might be useful for this, so can we leave this
patch out for now.


Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]