[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Fix reference leak in remoteDispatchStorageVolCreateXmlFrom



On Fri, Dec 11, 2009 at 02:13:24AM +0100, Matthias Bolte wrote:
> ---
>  daemon/remote.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/daemon/remote.c b/daemon/remote.c
> index 3117615..7a43046 100644
> --- a/daemon/remote.c
> +++ b/daemon/remote.c
> @@ -4118,12 +4118,15 @@ remoteDispatchStorageVolCreateXmlFrom (struct qemud_server *server ATTRIBUTE_UNU
>  
>      clonevol = get_nonnull_storage_vol (conn, args->clonevol);
>      if (clonevol == NULL) {
> +        virStoragePoolFree(pool);
>          remoteDispatchConnError(rerr, conn);
>          return -1;
>      }
>  
>      newvol = virStorageVolCreateXMLFrom (pool, args->xml, clonevol,
>                                           args->flags);
> +    virStorageVolFree(clonevol);
> +    virStoragePoolFree(pool);
>      if (newvol == NULL) {
>          remoteDispatchConnError(rerr, conn);
>          return -1;

  Hum, looks right, but how did you find this, valgrind the TCK ?

    ACK

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]