[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[libvirt] [PATCH 5/6] virsh: Enable virDomainMemoryStats as a new command



Define a new command 'dommemstats' to report domain memory statistics.  The
output format is inspired by 'domblkstat' and 'domifstat' and consists of
tag/value pairs, one per line.  The command can complete successfully and print
no output if virDomainMemoryStats is supported by the driver, but not the guest
operating system.

Sample output:

swap_in 0
swap_out 0
major_fault 54
minor_fault 58259
mem_free 499384320
mem_tot 514531328

All stats referring to a quantity of memory (eg. all above except major and
minor faults) represent the quantity in bytes.

Signed-off-by: Adam Litke <agl us ibm com>
To: libvirt list <libvir-list redhat com>
---
 tools/virsh.c |   55 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
 1 files changed, 55 insertions(+), 0 deletions(-)

diff --git a/tools/virsh.c b/tools/virsh.c
index 46c5454..283f794 100644
--- a/tools/virsh.c
+++ b/tools/virsh.c
@@ -874,6 +874,60 @@ cmdDomIfstat (vshControl *ctl, const vshCmd *cmd)
 }
 
 /*
+ * "dommemstats" command
+ */
+static const vshCmdInfo info_dommemstats[] = {
+    {"help", gettext_noop("get memory statistics for a domain")},
+    {"desc", gettext_noop("Get memory statistics for a runnng domain.")},
+    {NULL,NULL}
+};
+
+static const vshCmdOptDef opts_dommemstats[] = {
+    {"domain", VSH_OT_DATA, VSH_OFLAG_REQ, gettext_noop("domain name, id or uuid")},
+    {NULL, 0, 0, NULL}
+};
+
+static int
+cmdDomMemStats(vshControl *ctl, const vshCmd *cmd)
+{
+    virDomainPtr dom;
+    char *name;
+    struct _virDomainMemoryStat stats[VIR_MEMSTAT_NR_TAGS];
+    unsigned int nr_stats, i;
+
+    if (!vshConnectionUsability(ctl, ctl->conn, TRUE))
+        return FALSE;
+
+    if (!(dom = vshCommandOptDomain(ctl, cmd, &name)))
+        return FALSE;
+
+    nr_stats = virDomainMemoryStats (dom, stats, VIR_MEMSTAT_NR_TAGS);
+    if (nr_stats == -1) {
+        vshError(ctl, _("Failed to get memory statistics for domain %s"), name);
+        virDomainFree(dom);
+        return FALSE;
+    }
+
+    for (i = 0; i < nr_stats; i++) {
+        if (stats[i].tag == VIR_MEMSTAT_SWAP_IN)
+            vshPrint (ctl, "swap_in %llu\n", stats[i].val);
+        if (stats[i].tag == VIR_MEMSTAT_SWAP_OUT)
+            vshPrint (ctl, "swap_out %llu\n", stats[i].val);
+        if (stats[i].tag == VIR_MEMSTAT_MAJOR_FAULT)
+            vshPrint (ctl, "major_fault %llu\n", stats[i].val);
+        if (stats[i].tag == VIR_MEMSTAT_MINOR_FAULT)
+            vshPrint (ctl, "minor_fault %llu\n", stats[i].val);
+        if (stats[i].tag == VIR_MEMSTAT_MEM_FREE)
+            vshPrint (ctl, "free_memory %llu\n", stats[i].val);
+        if (stats[i].tag == VIR_MEMSTAT_MEM_TOTAL)
+            vshPrint (ctl, "total_memory %llu\n", stats[i].val);
+    }
+
+    virDomainFree(dom);
+    return TRUE;
+}
+
+/*
  * "suspend" command
  */
 static const vshCmdInfo info_suspend[] = {
@@ -7183,6 +7237,7 @@ static const vshCmdDef commands[] = {
     {"domstate", cmdDomstate, opts_domstate, info_domstate},
     {"domblkstat", cmdDomblkstat, opts_domblkstat, info_domblkstat},
     {"domifstat", cmdDomIfstat, opts_domifstat, info_domifstat},
+    {"dommemstats", cmdDomMemStats, opts_dommemstats, info_dommemstats},
     {"domxml-from-native", cmdDomXMLFromNative, opts_domxmlfromnative, info_domxmlfromnative},
     {"domxml-to-native", cmdDomXMLToNative, opts_domxmltonative, info_domxmltonative},
     {"dumpxml", cmdDumpXML, opts_dumpxml, info_dumpxml},
-- 
1.6.5


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]