[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] fix various breakages in qemu "virsh dump"



On Mon, Nov 30, 2009 at 10:13:34AM +0000, Daniel P. Berrange wrote:
> On Fri, Nov 27, 2009 at 06:33:13PM +0100, Paolo Bonzini wrote:
> > 1) qemuMigrateToCommand uses ">>" so we have to truncate the file
> > before starting the migration;
> > 
> > 2) the command wasn't updated to chown the driver and set/restore
> > the security lavels;
> > 
> > 3) the VM does not have to be resumed if migration fails;
> > 
> > 4) the file is not removed when migration fails.
> > 
> > * src/qemu/qemu_driver.c (qemuDomainCoreDump): Truncate file before
> > dumping, set/restore ownership and security labels for the file.
> > ---
> >  src/qemu/qemu_driver.c |   48 +++++++++++++++++++++++++++++++++++++++++++++---
> >  1 files changed, 45 insertions(+), 3 deletions(-)
> 
> 
> ACK, looks good.

  Yup, pushed, I just had to slightly rebase the patch,

   thanks !

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]