[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Fix memory leak in qemudBuildCommandLine



On Mon, Dec 14, 2009 at 11:59:42PM +0100, Matthias Bolte wrote:
> ---
>  src/qemu/qemu_conf.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c
> index 86172c6..2ee2042 100644
> --- a/src/qemu/qemu_conf.c
> +++ b/src/qemu/qemu_conf.c
> @@ -1893,7 +1893,7 @@ int qemudBuildCommandLine(virConnectPtr conn,
>          }
>  
>          ADD_ARG_LIT("-monitor");
> -        ADD_ARG_LIT(virBufferContentAndReset(&buf));
> +        ADD_ARG(virBufferContentAndReset(&buf));
>      }
>  
>      if (def->localtime)

  haha, there was another one of that kind not that long ago, good catch !

   ACK, thanks !

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]