[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v3 01/13] XML schema for CPU flags



> >    <define name='uint'>
> > -    <data type='string'>
> > +    <data type='unsignedInt'>
> >        <param name="pattern">[0-9]+</param>
> >      </data>
> >    </define>
> 
>   Hum, why do you change this ?

Because you wanted me to do so last time you reviewed this patch :-)

> But basically if you use http://www.w3.org/TR/xmlschema-2/#unsignedInt
> as the base type then the pattern restriction is superfluous.

It's derived (transitively) from nonNegativeInteger by setting maxInclusive.
Since, nonNegativeInteger allows '+' sign at the beginning and I wanted to
disallow that. Perhaps I'm reading that specification in a wrong way...

> [...]
> > +  <define name='positiveInteger'>
> > +    <data type='positiveInteger'>
> > +      <param name="pattern">[0-9]+</param>
> > +    </data>
> > +  </define>
> 
>   Same here, but it's nitpick, it should work as is, ACK,

Thanks.

Jirka


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]