[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 04/10] Add support for -device with audio devices



On Thu, Dec 17, 2009 at 10:06:22AM +0100, Daniel Veillard wrote:
> On Tue, Dec 15, 2009 at 03:14:44PM +0000, Daniel P. Berrange wrote:
> > The current syntax for audio devices is a horrible multiplexed
> > arg
> > 
> >     -soundhw sb16,pcspk,ac97
> > 
> > The new syntax is
> > 
> >     -device sb16
> >     -device ac97
> > ---
> >  src/qemu/qemu_conf.c |   72 +++++++++++++++++++++++++++++++++++++------------
> >  1 files changed, 54 insertions(+), 18 deletions(-)
> > 
> > diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c
> > index 79b7b00..8c44a93 100644
> > --- a/src/qemu/qemu_conf.c
> > +++ b/src/qemu/qemu_conf.c
> > @@ -1538,6 +1538,28 @@ qemuBuildHostNetStr(virConnectPtr conn,
> >      return 0;
> >  }
> >  
> > +static int
> > +qemuBuildSoundDevStr(virConnectPtr conn,
> > +                     virDomainSoundDefPtr sound,
> > +                     char **str)
> > +{
> > +    const char *model = virDomainSoundModelTypeToString(sound->model);
> > +
> > +    if (STREQ(model, "es1370"))
> > +        model = "ES1370";
> > +    else if (STREQ(model, "ac97"))
> > +        model = "AC97";
> 
>   I'm not sure I understand why those 2 strings need to be upper-cased

That's just the way QEMU wants these two devices named :-( Everything
else in QMEU is lowercase :-(


Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]