[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/6] domMemStats: Add domainMemoryStats method to struct _virDriver



On Thu, Dec 17, 2009 at 10:43:04AM +0000, Daniel P. Berrange wrote:
> On Fri, Dec 11, 2009 at 03:26:12PM -0500, Adam Litke wrote:
> > +
> > +typedef struct _virDomainMemoryStat virDomainMemoryStatStruct;
> > +
> > +struct _virDomainMemoryStat {
> > +    virDomainMemoryStatTags tag;
> 
> This should be an 'int', since enums have an ill-defined size for ABI

  Damn, I usually catch those !

yup that need change,

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]