[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/2] Don't mix LDFLAGS and LIBS in the configure script.



On Fri, Dec 18, 2009 at 10:48:28AM +0000, Daniel P. Berrange wrote:
> On Thu, Dec 17, 2009 at 10:56:25PM +0100, Diego Elio 'Flameeyes' Petten? wrote:
> > If you pass libraries in the LDFLAGS variable, and then try AC_CHECK_FUNCS
> > to find whether a function is present or not, it'll fail badly when using
> > the --as-needed linker flag.
> > 
> > Instead, pass the libraries through the LIBS library, so that they are
> > passed after the conftest.c source file and the tests are done properly.
> > ---
> >  configure.in |   30 +++++++++++++++---------------
> >  1 files changed, 15 insertions(+), 15 deletions(-)
> 
> ACK

  Yup, looks fine,

   applied both, thanks !

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]