[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 5/6] virsh: Enable virDomainMemoryStats as a new command



On Sun, Dec 20, 2009 at 06:05:26PM +0000, Paul Jenner wrote:
> Hi Adam.
> 
> On Fri, 2009-12-18 at 13:17 -0500, Adam Litke wrote:
> > Define a new command 'dommemstats' to report domain memory statistics.  The
> > output format is inspired by 'domblkstat' and 'domifstat'
> 
> Minor point but as this is inspired by existing 'domblkstat' and
> 'domifstat', why 'dommemstats' instead of 'dommemstat'? The
> inconsistency here seems like it could confuse a user.

Agreed, lets keep this new one to be same convention

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]