[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 5/6] virsh: Enable virDomainMemoryStats as a new command



On Mon, Dec 21, 2009 at 11:29:27AM +0000, Daniel P. Berrange wrote:
> On Sun, Dec 20, 2009 at 06:05:26PM +0000, Paul Jenner wrote:
> > Hi Adam.
> > 
> > On Fri, 2009-12-18 at 13:17 -0500, Adam Litke wrote:
> > > Define a new command 'dommemstats' to report domain memory statistics.  The
> > > output format is inspired by 'domblkstat' and 'domifstat'
> > 
> > Minor point but as this is inspired by existing 'domblkstat' and
> > 'domifstat', why 'dommemstats' instead of 'dommemstat'? The
> > inconsistency here seems like it could confuse a user.
> 
> Agreed, lets keep this new one to be same convention

  Yes, that makes sense, I just fixed this, thanks for raising the issue
  Paul !

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]