[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Fix floppy definition for HVM guests



Daniel P. Berrange wrote:
> On Wed, Jan 28, 2009 at 01:23:39PM -0800, john levon sun com wrote:
>> # HG changeset patch
>> # User john levon sun com
>> # Date 1233177786 28800
>> # Node ID 2b9283e83c20ca2a18f2cafcb963ce254e11dbb4
>> # Parent  9a9bd34ec485ebaf4c3861bdfffd2953fd91a1fc
>> Fix floppy definition for HVM guests
>>
>> Code was missing to define floppy disks for Xen HVM guests.  Refuse to
>> attach disks that aren't supported by direct attach.
>>
>> Signed-off-by: John Levon <john levon sun com>
> 
> ACK.
> 
> I see we're also missing floppy disk support for the old XM driver too.
> I could have sworn I'd seen a patch for this before though, so I'll try
> and find that code for XM.

Yes, I long ago posted a patch for XM HVM floppy support.  The problem was that
at the time, something in that area was being re-factored, so we decided to
defer it.  I just never got back to it.  It should be simple enough to dig up my
patch and massage it in, though; the patch was fairly simple.

-- 
Chris Lalancette


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]